Skip to content

[FSSDK-12150] [Ruby] Add Event Retries #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
esrakartalOpt wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[FSSDK-12150] [Ruby] Add Event Retries #385

esrakartalOpt wants to merge 4 commits into from

Conversation

@esrakartalOpt
Copy link
Contributor

@esrakartalOpt esrakartalOpt commented Jan 13, 2026 •
edited
Loading

Summary

Implements exponential backoff retry strategy for event dispatching to improve reliability and reduce server load during transient failures.

Changes

  • Batch Event Processor: Added retry logic with exponential backoff (3 attempts: 200ms → 400ms → 800ms, capped at 1s) in background thread to avoid blocking user code
  • ODP Event Manager: Added exponential backoff delays to existing retry loop
  • Constants: Added retry configuration (MAX_RETRIES: 3, INITIAL_RETRY_INTERVAL: 0.2, MAX_RETRY_INTERVAL: 1.0)
  • Tests: Added comprehensive test coverage for retry behavior and exponential backoff

Retry Behavior

  • Retries on: Any StandardError during event dispatch (5xx server errors, timeouts, network errors, etc.)
  • No retry on: 4xx client errors are logged but not retried (handled by EventDispatcher)
  • Max attempts: 3 (1 initial + 2 retries)
  • Backoff intervals: 200ms → 400ms → 800ms (capped at 1 second)

Test plan

PR Checks

Issues

pvcraven
pvcraven approved these changes Jan 14, 2026
View reviewed changes
Copy link

@pvcraven pvcraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but has confusing log message:

In batch_event_processor.rb:199:

"Retrying event dispatch (attempt #{retry_count} of #{max_retries - 1})"
With max_retries = 3 and retry_count = 1, 2:

Logs "attempt 1 of 2" and "attempt 2 of 2"
But there are 3 total attempts (1 initial + 2 retries)
Suggestion: Either:

Change to "attempt #{retry_count + 1} of #{max_retries}" → "attempt 2 of 3", "attempt 3 of 3"
Or "retry #{retry_count} of #{max_retries - 1}" → "retry 1 of 2", "retry 2 of 2"
Same issue in odp_event_manager.rb:245

Mat001
Mat001 approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mat001 Mat001 Mat001 approved these changes

@pvcraven pvcraven pvcraven approved these changes

Assignees

@esrakartalOpt esrakartalOpt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@esrakartalOpt @Mat001 @pvcraven